Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote distroless otel init image #10257

Merged
merged 1 commit into from
Aug 2, 2023
Merged

promote distroless otel init image #10257

merged 1 commit into from
Aug 2, 2023

Conversation

esigo
Copy link
Member

@esigo esigo commented Jul 29, 2023 •
edited
Loading

What this PR does / why we need it:

This PR promote distroless OpenTelemetry image added in #10035

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

telemetry traces tested in local deployment.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2023
@netlify
Copy link

netlify bot commented Jul 29, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit d4aab45
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/64c54b743b03290008a23a9a

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2023
@k8s-ci-robot k8s-ci-robot added the area/helm Issues or PRs related to helm charts label Jul 29, 2023
@esigo
Copy link
Member Author

esigo commented Jul 29, 2023 •
edited
Loading

/ok-to-test
/triage accepted

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 29, 2023
@esigo
Copy link
Member Author

esigo commented Jul 29, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 29, 2023
@strongjz
Copy link
Member

strongjz commented Aug 2, 2023

/lgtm
/cherry-pick release 1.8

@k8s-infra-cherrypick-robot
Copy link
Contributor

@strongjz: once the present PR merges, I will cherry-pick it on top of release 1.8 in a new PR and assign it to you.

In response to this:

/lgtm
/cherry-pick release 1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: esigo, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3baa591 into kubernetes:main Aug 2, 2023
37 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor

@strongjz: cannot checkout release 1.8: error checking out release 1.8: exit status 1. output: error: pathspec 'release 1.8' did not match any file(s) known to git

In response to this:

/lgtm
/cherry-pick release 1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@strongjz
Copy link
Member

strongjz commented Aug 2, 2023

/cherry-pick release-1.8

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 2, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link
Contributor

@strongjz: new pull request created: #10270

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danopia danopia mentioned this pull request Sep 10, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@strongjz strongjz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@esigo @strongjz @k8s-infra-cherrypick-robot @k8s-ci-robot